Ethanfel
bc6e30a2d4
Pinning 2 of 3 panels previously showed a 3rd "leftover" tab-column, which read as all-three-pinned and was confusing. Now the split view shows exactly the pinned panels (pin 2 -> 2 columns, pin 3 -> 3). Adds an always-available View > Side-by-side panels submenu of checkable toggles as the way to pin a panel while already in split view (the right-click-tab gesture only works in tabbed mode). Tests assert exactly-N-columns and the menu-pin path; the win fixture now resets deck state so tests don't depend on persisted layout. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
110 lines
3.8 KiB
Python
110 lines
3.8 KiB
Python
import pytest
|
|
|
|
# A real platform is needed because MpvWidget creates a GL context.
|
|
# If construction fails for any environment reason, skip — this test is a
|
|
# best-effort structural net, not a gate on core/ tests.
|
|
pytestmark = pytest.mark.gui
|
|
|
|
|
|
@pytest.fixture(scope="module")
|
|
def app():
|
|
from PyQt6.QtWidgets import QApplication
|
|
inst = QApplication.instance() or QApplication([])
|
|
yield inst
|
|
|
|
|
|
@pytest.fixture
|
|
def win(app):
|
|
try:
|
|
from main import MainWindow
|
|
w = MainWindow()
|
|
except Exception as e: # GL/mpv/display unavailable, etc.
|
|
pytest.skip(f"MainWindow could not be constructed here: {e}")
|
|
# Deterministic deck state regardless of any persisted side-by-side layout
|
|
# (construction restores deck_pinned from QSettings).
|
|
for _p in w._deck_panels:
|
|
_p._pinned = False
|
|
w._refresh_deck_layout()
|
|
yield w
|
|
w.close()
|
|
w.deleteLater()
|
|
|
|
|
|
def test_window_constructs(win):
|
|
assert win.windowTitle().startswith("8-cut")
|
|
|
|
|
|
def test_status_bar_exists(win):
|
|
assert win.statusBar() is not None
|
|
|
|
|
|
def test_workers_spinbox_in_export_tab(win):
|
|
from PyQt6.QtWidgets import QSpinBox
|
|
assert win._spn_workers in win._tab_export.findChildren(QSpinBox)
|
|
|
|
|
|
def test_scan_button_in_scan_tab(win):
|
|
from PyQt6.QtWidgets import QPushButton
|
|
assert win._btn_scan in win._tab_scan.findChildren(QPushButton)
|
|
|
|
|
|
def test_portrait_combo_in_crop_tab(win):
|
|
from PyQt6.QtWidgets import QComboBox
|
|
assert win._cmb_portrait in win._tab_crop.findChildren(QComboBox)
|
|
|
|
|
|
def test_menu_only_buttons_not_in_deck(win):
|
|
from PyQt6.QtWidgets import QPushButton
|
|
deck_btns = win._control_deck.findChildren(QPushButton)
|
|
assert win._btn_train not in deck_btns
|
|
assert win._btn_scan_all not in deck_btns
|
|
assert win._btn_hide_subcats not in deck_btns
|
|
|
|
|
|
def test_deck_stack_exists(win):
|
|
# The deck is wrapped in a stack so it can swap tabbed <-> side-by-side.
|
|
# Default (nothing pinned) shows the tabbed control deck.
|
|
assert win._deck_stack is not None
|
|
assert win._deck_stack.currentWidget() is win._control_deck
|
|
|
|
|
|
def _split_columns(win):
|
|
"""Widgets of the splitter actually mounted in the layout (not findChild,
|
|
which can return a stale deleteLater'd splitter)."""
|
|
from PyQt6.QtWidgets import QSplitter
|
|
item = win._deck_split_layout.itemAt(0)
|
|
spl = item.widget() if item else None
|
|
assert isinstance(spl, QSplitter)
|
|
return [spl.widget(i) for i in range(spl.count())]
|
|
|
|
|
|
def test_pinning_two_panels_shows_exactly_two_columns(win):
|
|
# Pin two panels directly (avoid the toggle handler so no QSettings write
|
|
# leaks into other test windows) and refresh.
|
|
from PyQt6.QtWidgets import QTabWidget
|
|
win._tab_export._pinned = True
|
|
win._tab_crop._pinned = True
|
|
win._refresh_deck_layout()
|
|
assert win._deck_stack.currentWidget() is win._deck_split_container
|
|
cols = _split_columns(win)
|
|
assert len(cols) == 2 # only the pinned ones
|
|
assert not any(isinstance(c, QTabWidget) for c in cols) # no leftover tab-column
|
|
|
|
|
|
def test_side_by_side_menu_pins_third_panel(win):
|
|
# In split mode the View ▸ Side-by-side menu is the way to pin a 3rd panel
|
|
# (there's no tab bar to right-click). Suppress the QSettings save via the
|
|
# _deck_loading guard so this doesn't leak into other windows.
|
|
win._tab_export._pinned = True
|
|
win._tab_scan._pinned = True
|
|
win._refresh_deck_layout()
|
|
assert len(_split_columns(win)) == 2
|
|
act = next(a for a, p in win._deck_pin_actions if p is win._tab_crop)
|
|
win._deck_loading = True # suppress _save_deck_layout
|
|
try:
|
|
act.trigger() # simulate clicking the menu item
|
|
finally:
|
|
win._deck_loading = False
|
|
assert win._tab_crop._pinned is True
|
|
assert len(_split_columns(win)) == 3
|