From 340c0aa402fdf8b56fad5eb1559ff901c7fc7cfc Mon Sep 17 00:00:00 2001 From: Ethanfel Date: Sun, 5 Apr 2026 20:44:27 +0200 Subject: [PATCH] =?UTF-8?q?simplify:=20remove=20language=20param=20entirel?= =?UTF-8?q?y=20=E2=80=94=20model=20detects=20from=20instruct=20string?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Chinese characters vs English words are self-identifying to the model. No need for a separate language signal on either node. Co-Authored-By: Claude Sonnet 4.6 --- nodes/generator.py | 11 +---------- nodes/voice_design.py | 8 ++++---- 2 files changed, 5 insertions(+), 14 deletions(-) diff --git a/nodes/generator.py b/nodes/generator.py index 57e7037..9aecb2e 100644 --- a/nodes/generator.py +++ b/nodes/generator.py @@ -62,13 +62,6 @@ class OmniVoiceGenerate: "default": "", "tooltip": "Transcription of ref_audio. Connect a Whisper (or other STT) node for best results.", }), - "language": ("STRING", { - "default": "auto", - "tooltip": ( - "Connect the 'language' output from OmniVoice Voice Design — it sets this automatically.\n" - "Only needed in voice_design/auto_voice mode. Leave 'auto' for voice_cloning." - ), - }), "instruct": ("STRING", { "default": "", "tooltip": ( @@ -120,13 +113,11 @@ class OmniVoiceGenerate: FUNCTION = "generate" CATEGORY = "OmniVoice" - def generate(self, model, text, mode, ref_audio=None, ref_text="", language="auto", + def generate(self, model, text, mode, ref_audio=None, ref_text="", instruct="", guidance_scale=2.0, speed=1.0, num_step=32, seed=0): if seed != 0: torch.manual_seed(seed) kwargs = {"text": text, "speed": speed, "num_step": num_step, "guidance_scale": guidance_scale} - if mode != "voice_cloning" and language and language != "auto": - kwargs["language"] = language if mode == "voice_cloning" and ref_audio is None: raise ValueError("voice_cloning mode requires ref_audio to be connected") diff --git a/nodes/voice_design.py b/nodes/voice_design.py index 2ee4ecd..bd8ad28 100644 --- a/nodes/voice_design.py +++ b/nodes/voice_design.py @@ -59,8 +59,8 @@ class OmniVoiceVoiceDesign: }, } - RETURN_TYPES = ("STRING", "STRING") - RETURN_NAMES = ("instruct", "language") + RETURN_TYPES = ("STRING",) + RETURN_NAMES = ("instruct",) FUNCTION = "compose" CATEGORY = "OmniVoice" @@ -68,7 +68,7 @@ class OmniVoiceVoiceDesign: zh_gender="none", zh_age="none", zh_pitch="none", zh_dialect="none"): if language == "Chinese": parts = [v for v in [zh_gender, zh_age, zh_pitch, zh_dialect] if v != "none"] - return ("，".join(parts), "Chinese") + return ("，".join(parts),) else: parts = [v for v in [gender, age, pitch, accent] if v != "none"] - return (", ".join(parts), "English") + return (", ".join(parts),)