Ethanfel/ComfyUI-SelVA
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: SelvaSampler input order — prompt required, negative_prompt optional

Browse Source 
ComfyUI renders required inputs above optional ones. Moving negative_prompt
to optional puts prompt first (natural order) and negative_prompt at the
bottom where it belongs as a power-user input. Also guards against
negative_prompt=None when not connected.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Ethanfel
2026-04-04 16:27:07 +02:00
parent 9a985499e7
commit e3a3384727
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
nodes/selva_sampler.py
+6 -6
View File
@@ -11,9 +11,9 @@ class SelvaSampler:
"required": { "required": {
"model": ("SELVA_MODEL",), "model": ("SELVA_MODEL",),
"features": ("SELVA_FEATURES",), "features": ("SELVA_FEATURES",),
"negative_prompt": ("STRING", { "prompt": ("STRING", {
"default": "", "multiline": True, "default": "", "multiline": True,
"tooltip": "Sounds to steer away from, e.g. 'wind noise, background music'.", "tooltip": "CLIP text for audio generation. Leave empty to reuse the prompt from SelvaFeatureExtractor.",
}), }),
"duration": ("FLOAT", { "duration": ("FLOAT", {
"default": 0.0, "min": 0.0, "max": 30.0, "step": 0.1, "default": 0.0, "min": 0.0, "max": 30.0, "step": 0.1,
@@ -26,9 +26,9 @@ class SelvaSampler:
"seed": ("INT", {"default": 0, "min": 0, "max": 0xFFFFFFFF}), "seed": ("INT", {"default": 0, "min": 0, "max": 0xFFFFFFFF}),
}, },
"optional": { "optional": {
"prompt": ("STRING", { "negative_prompt": ("STRING", {
"default": "", "multiline": True, "default": "", "multiline": True,
"tooltip": "CLIP text for audio generation. Leave empty to reuse the prompt from SelvaFeatureExtractor.", "tooltip": "Sounds to steer away from, e.g. 'wind noise, background music'.",
}), }),
}, },
} }
@@ -38,7 +38,7 @@ class SelvaSampler:
FUNCTION = "generate" FUNCTION = "generate"
CATEGORY = PRISMAUDIO_CATEGORY CATEGORY = PRISMAUDIO_CATEGORY
def generate(self, model, features, negative_prompt, duration, steps, cfg_strength, seed, prompt=None): def generate(self, model, features, prompt, duration, steps, cfg_strength, seed, negative_prompt=None):
from selva_core.model.flow_matching import FlowMatching from selva_core.model.flow_matching import FlowMatching
from selva_core.model.sequence_config import SequenceConfig from selva_core.model.sequence_config import SequenceConfig
@@ -96,7 +96,7 @@ class SelvaSampler:
# Encode negative prompt (or use empty conditions) # Encode negative prompt (or use empty conditions)
neg_text_clip = feature_utils.encode_text_clip([negative_prompt]) \ neg_text_clip = feature_utils.encode_text_clip([negative_prompt]) \
if negative_prompt.strip() else None if negative_prompt and negative_prompt.strip() else None
conditions = net_generator.preprocess_conditions(clip_f, sync_f, text_clip) conditions = net_generator.preprocess_conditions(clip_f, sync_f, text_clip)
empty_conditions = net_generator.get_empty_conditions( empty_conditions = net_generator.get_empty_conditions(