Ethanfel/ComfyUI-Sharp-Selector
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix argument too long error by using ffmetadata file for video metadata

Browse Source 
Write metadata to a temp file and pass via -i/-map_metadata instead of
command-line -metadata flags to avoid OS argument length limits with
large ComfyUI workflow JSON.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
Ethanfel
2026-02-03 00:11:20 +01:00
parent 59bd805920
commit f02851d88a
1 changed files with 28 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

37
fast_saver.py
View File

@@ -13,6 +13,7 @@ import json
import subprocess import subprocess
import shutil import shutil
import stat import stat
import tempfile
import urllib.request import urllib.request
import zipfile import zipfile
import tarfile import tarfile
@@ -272,22 +273,30 @@ class FastAbsoluteSaver:
batch_size = len(images) batch_size = len(images)
h, w = images[0].shape[0], images[0].shape[1] h, w = images[0].shape[0], images[0].shape[1]
# --- BUILD METADATA FLAGS --- # --- BUILD METADATA FILE (avoids arg-too-long for large workflows) ---
meta_flags = [] meta_lines = [";FFMETADATA1"]
meta_lines.append("software=ComfyUI_FastAbsoluteSaver")
if scores_list: if scores_list:
avg_score = sum(scores_list) / len(scores_list) avg_score = sum(scores_list) / len(scores_list)
meta_flags += ["-metadata", f"{metadata_key}_avg={avg_score:.2f}"] meta_lines.append(f"{metadata_key}_avg={avg_score:.2f}")
meta_flags += ["-metadata", f"{metadata_key}_all={','.join(f'{s:.2f}' for s in scores_list)}"] meta_lines.append(f"{metadata_key}_all={','.join(f'{s:.2f}' for s in scores_list)}")
if save_workflow: if save_workflow:
if prompt_data: if prompt_data:
meta_flags += ["-metadata", f"prompt={json.dumps(prompt_data)}"] # Escape ffmetadata special chars: =, ;, #, \ and newlines
prompt_str = json.dumps(prompt_data).replace("\\", "\\\\").replace("=", "\\=").replace(";", "\\;").replace("#", "\\#").replace("\n", "\\\n")
meta_lines.append(f"prompt={prompt_str}")
if extra_data: if extra_data:
workflow = extra_data.get("workflow", {}) workflow = extra_data.get("workflow", {})
if workflow: if workflow:
meta_flags += ["-metadata", f"workflow={json.dumps(workflow)}"] workflow_str = json.dumps(workflow).replace("\\", "\\\\").replace("=", "\\=").replace(";", "\\;").replace("#", "\\#").replace("\n", "\\\n")
meta_lines.append(f"workflow={workflow_str}")
meta_flags += ["-metadata", "software=ComfyUI_FastAbsoluteSaver"] self._meta_tmpfile = tempfile.NamedTemporaryFile(mode="w", suffix=".txt", delete=False, encoding="utf-8")
self._meta_tmpfile.write("\n".join(meta_lines))
self._meta_tmpfile.close()
meta_file = self._meta_tmpfile.name
if video_format == "mp4": if video_format == "mp4":
codec = "libx264" codec = "libx264"
@@ -296,10 +305,12 @@ class FastAbsoluteSaver:
"-f", "rawvideo", "-pix_fmt", "rgb24", "-f", "rawvideo", "-pix_fmt", "rgb24",
"-s", f"{w}x{h}", "-r", str(fps), "-s", f"{w}x{h}", "-r", str(fps),
"-i", "-", "-i", "-",
"-i", meta_file, "-map_metadata", "1",
"-c:v", codec, "-crf", str(crf), "-c:v", codec, "-crf", str(crf),
"-pix_fmt", pixel_format, "-pix_fmt", pixel_format,
"-movflags", "+faststart", "-movflags", "+faststart",
] + meta_flags + [out_file] out_file
]
else: # webm else: # webm
codec = "libvpx-vp9" codec = "libvpx-vp9"
cmd = [ cmd = [
@@ -307,9 +318,11 @@ class FastAbsoluteSaver:
"-f", "rawvideo", "-pix_fmt", "rgb24", "-f", "rawvideo", "-pix_fmt", "rgb24",
"-s", f"{w}x{h}", "-r", str(fps), "-s", f"{w}x{h}", "-r", str(fps),
"-i", "-", "-i", "-",
"-i", meta_file, "-map_metadata", "1",
"-c:v", codec, "-crf", str(crf), "-b:v", "0", "-c:v", codec, "-crf", str(crf), "-b:v", "0",
"-pix_fmt", pixel_format, "-pix_fmt", pixel_format,
] + meta_flags + [out_file] out_file
]
print(f"xx- FastSaver: Encoding {batch_size} frames to {out_file} ({codec}, crf={crf}, {fps}fps)...") print(f"xx- FastSaver: Encoding {batch_size} frames to {out_file} ({codec}, crf={crf}, {fps}fps)...")
@@ -324,6 +337,12 @@ class FastAbsoluteSaver:
stderr = proc.stderr.read() stderr = proc.stderr.read()
proc.wait() proc.wait()
# Clean up metadata temp file
try:
os.remove(meta_file)
except OSError:
pass
if proc.returncode != 0: if proc.returncode != 0:
raise RuntimeError(f"ffmpeg failed: {stderr.decode()}") raise RuntimeError(f"ffmpeg failed: {stderr.decode()}")