Ethanfel/Comfyui-JSON-Manager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix dynamic node outputs using LiteGraph removeOutput/addOutput API

Browse Source 
Direct array manipulation bypassed LiteGraph's internal slot tracking,
causing output names to show as defaults instead of JSON key names.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Ethanfel
2026-02-23 15:57:06 +01:00
parent 8cc244e8be
commit 0d44944192
1 changed files with 18 additions and 58 deletions
Download Patch File Download Diff File Expand all files Collapse all files

76
web/json_dynamic.js
View File

@@ -18,21 +18,15 @@ app.registerExtension({
okWidget.computeSize = () => [0, -4]; okWidget.computeSize = () => [0, -4];
} }
// Hide all 32 outputs initially // Remove all 32 default outputs from Python RETURN_TYPES
this._dynamicOutputCount = 0; while (this.outputs.length > 0) {
for (let i = 0; i < this.outputs.length; i++) { this.removeOutput(0);
this.outputs[i]._visible = false;
} }
// Add Refresh button // Add Refresh button
this.addWidget("button", "Refresh Outputs", null, () => { this.addWidget("button", "Refresh Outputs", null, () => {
this.refreshDynamicOutputs(); this.refreshDynamicOutputs();
}); });
// Store original outputs array for show/hide
this._allOutputs = [...this.outputs];
// Start with no visible outputs
this.outputs.length = 0;
}; };
nodeType.prototype.refreshDynamicOutputs = async function () { nodeType.prototype.refreshDynamicOutputs = async function () {
@@ -46,39 +40,19 @@ app.registerExtension({
); );
const { keys } = await resp.json(); const { keys } = await resp.json();
// Update output_keys widget for Python to read // Update output_keys widget for Python to read at execution time
const okWidget = this.widgets?.find(w => w.name === "output_keys"); const okWidget = this.widgets?.find(w => w.name === "output_keys");
if (okWidget) okWidget.value = keys.join(","); if (okWidget) okWidget.value = keys.join(",");
// Restore full outputs array to manipulate // Remove all current outputs (disconnects links properly)
if (this._allOutputs) { while (this.outputs.length > 0) {
this.outputs = this._allOutputs; this.removeOutput(0);
} }
// Disconnect any links on outputs that will be hidden // Add an output slot for each discovered key
for (let i = keys.length; i < 32; i++) { for (const key of keys) {
if (this.outputs[i]?.links?.length) { this.addOutput(key, "*");
for (const linkId of [...this.outputs[i].links]) {
this.graph?.removeLink(linkId);
} }
}
}
// Rename visible outputs to key names
for (let i = 0; i < 32; i++) {
if (i < keys.length) {
this.outputs[i].name = keys[i];
this.outputs[i]._visible = true;
} else {
this.outputs[i].name = `output_${i}`;
this.outputs[i]._visible = false;
}
}
// Truncate outputs array to only show active ones
this._dynamicOutputCount = keys.length;
this._allOutputs = [...this.outputs];
this.outputs.length = keys.length;
this.setSize(this.computeSize()); this.setSize(this.computeSize());
app.graph.setDirtyCanvas(true, true); app.graph.setDirtyCanvas(true, true);
@@ -87,7 +61,7 @@ app.registerExtension({
} }
}; };
// Override configure to restore state on workflow load // Restore state on workflow load
const origOnConfigure = nodeType.prototype.onConfigure; const origOnConfigure = nodeType.prototype.onConfigure;
nodeType.prototype.onConfigure = function (info) { nodeType.prototype.onConfigure = function (info) {
origOnConfigure?.apply(this, arguments); origOnConfigure?.apply(this, arguments);
@@ -102,30 +76,16 @@ app.registerExtension({
? okWidget.value.split(",").filter(k => k.trim()) ? okWidget.value.split(",").filter(k => k.trim())
: []; : [];
// Ensure we have the full 32 outputs stored // On load, LiteGraph already restored serialized outputs with links.
this._allOutputs = [...this.outputs]; // Just rename to match keys (preserves links) and trim excess.
while (this._allOutputs.length < 32) { for (let i = 0; i < this.outputs.length && i < keys.length; i++) {
this._allOutputs.push({ this.outputs[i].name = keys[i].trim();
name: `output_${this._allOutputs.length}`,
type: "*",
links: null,
_visible: false,
});
} }
// Rename and set visibility // Remove any extra outputs beyond the key count
for (let i = 0; i < 32; i++) { while (this.outputs.length > keys.length) {
if (i < keys.length) { this.removeOutput(this.outputs.length - 1);
this._allOutputs[i].name = keys[i].trim();
this._allOutputs[i]._visible = true;
} else {
this._allOutputs[i].name = `output_${i}`;
this._allOutputs[i]._visible = false;
} }
}
this._dynamicOutputCount = keys.length;
this.outputs = this._allOutputs.slice(0, keys.length);
this.setSize(this.computeSize()); this.setSize(this.computeSize());
}; };