Ethanfel/Comfyui-JSON-Manager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Clean up: remove unnecessary info.outputs logic, set label on reused slots

Browse Source 
The actual fix was setting slot.label alongside slot.name. Reverted
onConfigure to read from widget values (which work correctly) and
ensured label is set on both new and reused output slots.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Ethanfel
2026-03-01 00:12:30 +01:00
parent a0d8cb8bbf
commit 187b85b054
1 changed files with 11 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

49
web/project_dynamic.js
View File

@@ -143,6 +143,7 @@ app.registerExtension({
if (key in oldSlots) { if (key in oldSlots) {
const slot = this.outputs[oldSlots[key]]; const slot = this.outputs[oldSlots[key]];
slot.type = type; slot.type = type;
slot.label = key;
newOutputs.push(slot); newOutputs.push(slot);
delete oldSlots[key]; delete oldSlots[key];
} else { } else {
@@ -197,37 +198,12 @@ app.registerExtension({
const okWidget = this.widgets?.find(w => w.name === "output_keys"); const okWidget = this.widgets?.find(w => w.name === "output_keys");
const otWidget = this.widgets?.find(w => w.name === "output_types"); const otWidget = this.widgets?.find(w => w.name === "output_types");
// Primary source: read output names from serialized node info. const keys = okWidget?.value
// Hidden widget values may not survive ComfyUI's serialization, ? okWidget.value.split(",").filter(k => k.trim())
// but info.outputs always contains the correct saved output names. : [];
let keys = []; const types = otWidget?.value
let types = []; ? otWidget.value.split(",")
const savedOutputs = info.outputs || []; : [];
for (let i = 0; i < savedOutputs.length; i++) {
if (savedOutputs[i].name === "total_sequences") continue;
if (/^output_\d+$/.test(savedOutputs[i].name)) continue;
keys.push(savedOutputs[i].name);
types.push(savedOutputs[i].type || "*");
}
// Fallback: try hidden widget values
if (keys.length === 0) {
const wKeys = okWidget?.value
? okWidget.value.split(",").filter(k => k.trim())
: [];
if (wKeys.length > 0) {
keys = wKeys;
types = otWidget?.value
? otWidget.value.split(",")
: [];
}
}
// Update hidden widgets so the Python backend has keys for execution
if (keys.length > 0) {
if (okWidget) okWidget.value = keys.join(",");
if (otWidget) otWidget.value = types.join(",");
}
// Ensure slot 0 is total_sequences (INT) // Ensure slot 0 is total_sequences (INT)
if (this.outputs.length === 0 || this.outputs[0].name !== "total_sequences") { if (this.outputs.length === 0 || this.outputs[0].name !== "total_sequences") {
@@ -267,13 +243,10 @@ app.registerExtension({
this.removeOutput(this.outputs.length - 1); this.removeOutput(this.outputs.length - 1);
} }
} else if (this.outputs.length > 1) { } else if (this.outputs.length > 1) {
const dynamicOutputs = this.outputs.slice(1).filter( // Widget values empty but serialized dynamic outputs exist — sync widgets
o => !/^output_\d+$/.test(o.name) const dynamicOutputs = this.outputs.slice(1);
); if (okWidget) okWidget.value = dynamicOutputs.map(o => o.name).join(",");
if (dynamicOutputs.length > 0) { if (otWidget) otWidget.value = dynamicOutputs.map(o => o.type).join(",");
if (okWidget) okWidget.value = dynamicOutputs.map(o => o.name).join(",");
if (otWidget) otWidget.value = dynamicOutputs.map(o => o.type).join(",");
}
} }
this.setSize(this.computeSize()); this.setSize(this.computeSize());