Ethanfel/Comfyui-JSON-Manager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: remove _refreshKeys from onMouseDown to prevent key reset

Browse Source 
The async _refreshKeys call on every mouse click caused a race condition
where clicking the key_name dropdown would trigger a re-fetch that
overwrote the user's selection. Keys are now only refreshed on source
label change and workflow load.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Ethanfel
2026-03-20 21:00:19 +01:00
parent ff5802ab63
commit 6e232da193
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
web/project_key.js
+2 -3
View File
@@ -200,7 +200,7 @@ app.registerExtension({
app.graph?.setDirtyCanvas(true, true); app.graph?.setDirtyCanvas(true, true);
}; };
// --- Sync + refresh on click (catches changes pushed from source) --- // --- Sync config on click (lazy, no key refresh to avoid race) ---
const origOnMouseDown = nodeType.prototype.onMouseDown; const origOnMouseDown = nodeType.prototype.onMouseDown;
nodeType.prototype.onMouseDown = function (e, localPos, graphCanvas) { nodeType.prototype.onMouseDown = function (e, localPos, graphCanvas) {
origOnMouseDown?.apply(this, arguments); origOnMouseDown?.apply(this, arguments);
@@ -208,9 +208,8 @@ app.registerExtension({
if (srcWidget) { if (srcWidget) {
srcWidget.options.values = this._getSourceLabels(); srcWidget.options.values = this._getSourceLabels();
} }
// Always re-sync config from source and refresh keys on interaction // Sync config values from source (synchronous, safe)
this._syncFromSource(); this._syncFromSource();
this._refreshKeys();
}; };
// --- Restore state on workflow load --- // --- Restore state on workflow load ---