Ethanfel/Comfyui-JSON-Manager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: prevent undefined in combo widgets with empty values

Browse Source 
Combo widgets show "undefined" when values list is empty. Now ensures
at least one entry (empty string placeholder) and picks a valid default.
Also populates source labels immediately on node creation.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Ethanfel
2026-03-19 15:34:01 +01:00
parent 77eb3473ab
commit bd36b4b725
1 changed files with 10 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
web/project_key.js
+10 -3
View File
@@ -33,10 +33,13 @@ app.registerExtension({
if (idx === -1 || idx === undefined) return null; if (idx === -1 || idx === undefined) return null;
const oldWidget = node.widgets[idx]; const oldWidget = node.widgets[idx];
const savedValue = oldWidget.value || ""; const savedValue = oldWidget.value || "";
// Ensure values list is never empty (combo shows undefined otherwise)
const comboValues = values.length > 0 ? values : [""];
const defaultValue = comboValues.includes(savedValue) ? savedValue : comboValues[0];
// Remove old STRING widget // Remove old STRING widget
node.widgets.splice(idx, 1); node.widgets.splice(idx, 1);
// Insert a real combo widget at the same position // Insert a real combo widget at the same position
const combo = node.addWidget("combo", name, savedValue, callback, { values: values }); const combo = node.addWidget("combo", name, defaultValue, callback, { values: comboValues });
// Move it from the end to the original position // Move it from the end to the original position
if (node.widgets.length > 1) { if (node.widgets.length > 1) {
node.widgets.splice(node.widgets.length - 1, 1); node.widgets.splice(node.widgets.length - 1, 1);
@@ -58,15 +61,19 @@ app.registerExtension({
// Replace source_label STRING with a proper combo widget // Replace source_label STRING with a proper combo widget
const node = this; const node = this;
replaceWithCombo(this, "source_label", [], function (value) { const sourceLabels = this._getSourceLabels?.() || [];
const srcCombo = replaceWithCombo(this, "source_label", sourceLabels, function (value) {
node._syncFromSource(); node._syncFromSource();
node._refreshKeys(); node._refreshKeys();
}); });
// Set first available source or "none" placeholder
if (srcCombo) srcCombo.value = sourceLabels[0] || "";
// Replace key_name STRING with a proper combo widget // Replace key_name STRING with a proper combo widget
replaceWithCombo(this, "key_name", [], function (value) { const keyCombo = replaceWithCombo(this, "key_name", [], function (value) {
node._applyKeySelection(); node._applyKeySelection();
}); });
if (keyCombo) keyCombo.value = "";
queueMicrotask(() => { queueMicrotask(() => {
if (!this._configured) { if (!this._configured) {