From ac189d75ba00d0311cf8f731a990f66c8f8b8bda Mon Sep 17 00:00:00 2001 From: Ethanfel Date: Mon, 19 Jan 2026 15:29:38 +0100 Subject: [PATCH 01/11] Update engine.py --- engine.py | 26 +++++++++++++++++++++++++- 1 file changed, 25 insertions(+), 1 deletion(-) diff --git a/engine.py b/engine.py index 72a10dc..6a63dd8 100644 --- a/engine.py +++ b/engine.py @@ -501,4 +501,28 @@ class SorterEngine: cursor.execute("DELETE FROM categories WHERE name = ?", (name,)) cursor.execute("DELETE FROM staging_area WHERE target_category = ?", (name,)) conn.commit() - conn.close() \ No newline at end of file + conn.close() + + @staticmethod + def get_tagged_page_indices(all_images, page_size): + """ + Returns a Set of page numbers (0-indexed) that contain at least one staged image. + """ + staged = SorterEngine.get_staged_data() + if not staged: + return set() + + tagged_pages = set() + staged_keys = set(staged.keys()) + + # We iterate only through the staged items to find their page index + # This is faster than iterating all images if staged < total + # However, we need the index from the main list. + # Since we need order, iterating all_images once is safest and fast enough. + + for idx, img_path in enumerate(all_images): + if img_path in staged_keys: + page_idx = idx // page_size + tagged_pages.add(page_idx) + + return tagged_pages \ No newline at end of file From 470e3114c466674a8ee6c64bbb151018a6ae045c Mon Sep 17 00:00:00 2001 From: Ethanfel Date: Mon, 19 Jan 2026 15:32:22 +0100 Subject: [PATCH 02/11] Update tab_gallery_sorter.py --- tab_gallery_sorter.py | 89 +++++++++++++++++++++++++++++++++++++++---- 1 file changed, 81 insertions(+), 8 deletions(-) diff --git a/tab_gallery_sorter.py b/tab_gallery_sorter.py index 9ba4042..20b76eb 100644 --- a/tab_gallery_sorter.py +++ b/tab_gallery_sorter.py @@ -334,18 +334,91 @@ def render(quality, profile_name): end_idx = start_idx + page_size current_batch = all_images[start_idx:end_idx] - def nav_controls(key_suffix): - c1, c2, c3, c4 = st.columns([1.5, 1, 0.5, 1.5], vertical_alignment="center") - c1.button("⬅️ Prev", disabled=(st.session_state.t5_page == 0), on_click=cb_change_page, args=(-1,), key=f"p_{key_suffix}", use_container_width=True) - c2.number_input("Page", min_value=1, max_value=total_pages, value=st.session_state.t5_page + 1, step=1, label_visibility="collapsed", key=f"jump_{key_suffix}", on_change=cb_jump_page, args=(f"jump_{key_suffix}",)) - c3.markdown(f"
/ {total_pages}
", unsafe_allow_html=True) - c4.button("Next ➡️", disabled=(st.session_state.t5_page >= total_pages - 1), on_click=cb_change_page, args=(1,), key=f"n_{key_suffix}", use_container_width=True) + # Place this helper inside tab_gallery_sorter.py (or keep it if you have the old one) +def cb_set_page(page_idx): + st.session_state.t5_page = page_idx + +def render_pagination_carousel(key_suffix, total_pages, all_images, page_size): + """ + Renders a 'Carousel' style pagination with a slider for fast seeking + and buttons for precise selection with status indicators. + """ + current_page = st.session_state.t5_page + + # 1. CALCULATE TAGGED PAGES (For the Green Indicator) + # We do this once per render + tagged_pages_set = SorterEngine.get_tagged_page_indices(all_images, page_size) + + # --- A. RAPID SEEKER SLIDER (Debounced) --- + # Streamlit sliders only rerun the script on mouse release. + # This acts as your "wait a bit" logic. + new_page = st.slider( + "Rapid Navigation", + 0, total_pages - 1, current_page, + key=f"slider_{key_suffix}", + label_visibility="collapsed" + ) + + # If slider moved, update state and rerun + if new_page != current_page: + st.session_state.t5_page = new_page + st.rerun() + + # --- B. BUTTON CAROUSEL --- + # We want to show a window of pages: [Prev] .. [p-2] [p-1] [P] [p+1] [p+2] .. [Next] + + # Define window size (how many numbered buttons to show) + window_radius = 2 + start_p = max(0, current_page - window_radius) + end_p = min(total_pages, current_page + window_radius + 1) + + # Adjust window if we are near the start or end to keep number of buttons constant + if current_page < window_radius: + end_p = min(total_pages, 5) + elif current_page > total_pages - window_radius - 1: + start_p = max(0, total_pages - 5) + + # Layout: Prev + (Window Buttons) + Next + # Total columns = (end_p - start_p) + 2 buttons + num_page_buttons = end_p - start_p + cols = st.columns([1] + [1] * num_page_buttons + [1]) + + # 1. PREV BUTTON + with cols[0]: + st.button("◀", disabled=(current_page == 0), + on_click=cb_change_page, args=(-1,), + key=f"prev_{key_suffix}", use_container_width=True) + + # 2. PAGE NUMBER BUTTONS + for i, p_idx in enumerate(range(start_p, end_p)): + col_idx = i + 1 + with cols[col_idx]: + # Label Logic: Add 🟢 if tagged + label = str(p_idx + 1) + if p_idx in tagged_pages_set: + label += " 🟢" + + # Highlight current page using type="primary" + is_active = (p_idx == current_page) + btn_type = "primary" if is_active else "secondary" + + st.button(label, + type=btn_type, + key=f"btn_p{p_idx}_{key_suffix}", + use_container_width=True, + on_click=cb_set_page, args=(p_idx,)) + + # 3. NEXT BUTTON + with cols[-1]: + st.button("▶", disabled=(current_page >= total_pages - 1), + on_click=cb_change_page, args=(1,), + key=f"next_{key_suffix}", use_container_width=True) st.divider() - nav_controls("top") + render_pagination_carousel("top", total_pages, all_images, page_size) render_gallery_grid(current_batch, quality, grid_cols, path_o) st.divider() - nav_controls("bottom") + render_pagination_carousel("bot", total_pages, all_images, page_size) st.divider() render_batch_actions(current_batch, path_o, st.session_state.t5_page + 1, path_s) \ No newline at end of file From 69f34a84c44afa917bd249339fbfc7c6a8331f2e Mon Sep 17 00:00:00 2001 From: Ethanfel Date: Mon, 19 Jan 2026 15:36:25 +0100 Subject: [PATCH 03/11] Update tab_gallery_sorter.py --- tab_gallery_sorter.py | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/tab_gallery_sorter.py b/tab_gallery_sorter.py index 20b76eb..cac0c53 100644 --- a/tab_gallery_sorter.py +++ b/tab_gallery_sorter.py @@ -414,11 +414,18 @@ def render_pagination_carousel(key_suffix, total_pages, all_images, page_size): on_click=cb_change_page, args=(1,), key=f"next_{key_suffix}", use_container_width=True) - st.divider() - render_pagination_carousel("top", total_pages, all_images, page_size) - render_gallery_grid(current_batch, quality, grid_cols, path_o) - st.divider() - render_pagination_carousel("bot", total_pages, all_images, page_size) + # --- RENDER PAGE --- st.divider() - render_batch_actions(current_batch, path_o, st.session_state.t5_page + 1, path_s) \ No newline at end of file + # Replaces: nav_controls("top") + render_pagination_carousel("top", total_pages, all_images, page_size) + + # ... render_gallery_grid call ... + render_gallery_grid(current_batch, quality, grid_cols, path_o) + + st.divider() + + # Replaces: nav_controls("bottom") + render_pagination_carousel("bot", total_pages, all_images, page_size) + + st.divider() \ No newline at end of file From c9a2817f41322244633def2aa66d5f7646a529c3 Mon Sep 17 00:00:00 2001 From: Ethanfel Date: Mon, 19 Jan 2026 15:38:34 +0100 Subject: [PATCH 04/11] Update engine.py --- engine.py | 18 +++--------------- 1 file changed, 3 insertions(+), 15 deletions(-) diff --git a/engine.py b/engine.py index 6a63dd8..c43446b 100644 --- a/engine.py +++ b/engine.py @@ -503,26 +503,14 @@ class SorterEngine: conn.commit() conn.close() + # In engine.py / SorterEngine class @staticmethod def get_tagged_page_indices(all_images, page_size): - """ - Returns a Set of page numbers (0-indexed) that contain at least one staged image. - """ staged = SorterEngine.get_staged_data() - if not staged: - return set() - + if not staged: return set() tagged_pages = set() staged_keys = set(staged.keys()) - - # We iterate only through the staged items to find their page index - # This is faster than iterating all images if staged < total - # However, we need the index from the main list. - # Since we need order, iterating all_images once is safest and fast enough. - for idx, img_path in enumerate(all_images): if img_path in staged_keys: - page_idx = idx // page_size - tagged_pages.add(page_idx) - + tagged_pages.add(idx // page_size) return tagged_pages \ No newline at end of file From 024caac5e524839352a7efc8bd0c5da0e7844e53 Mon Sep 17 00:00:00 2001 From: Ethanfel Date: Mon, 19 Jan 2026 15:39:41 +0100 Subject: [PATCH 05/11] Update tab_gallery_sorter.py --- tab_gallery_sorter.py | 337 ++++++++++++++++-------------------------- 1 file changed, 127 insertions(+), 210 deletions(-) diff --git a/tab_gallery_sorter.py b/tab_gallery_sorter.py index cac0c53..523fa95 100644 --- a/tab_gallery_sorter.py +++ b/tab_gallery_sorter.py @@ -1,33 +1,20 @@ import streamlit as st import os import math +import concurrent.futures from engine import SorterEngine # ========================================== -# 1. CACHED DATA LOADER (The Fix) +# 1. CALLBACKS & STATE MANAGEMENT # ========================================== -@st.cache_data(show_spinner=False) -def get_cached_images(path, mutation_id): - """ - Scans the folder ONLY when 'path' or 'mutation_id' changes. - Navigating pages does NOT change these, so it remains instant. - """ - return SorterEngine.get_images(path, recursive=True) - -# ========================================== -# 2. CALLBACKS (Updated with Refresh Logic) -# ========================================== def trigger_refresh(): - """Increments the mutation counter to force a file re-scan.""" + """Forces the file cache to invalidate.""" if 't5_file_id' not in st.session_state: st.session_state.t5_file_id = 0 st.session_state.t5_file_id += 1 def cb_tag_image(img_path, selected_cat, index_val, path_o): - """ - Tags image with manual number. - Handles collisions by creating variants (e.g. _001_1) and warning the user. - """ + """Tags image with manual index and collision handling.""" if selected_cat.startswith("---") or selected_cat == "": st.toast("⚠️ Select a valid category first!", icon="🚫") return @@ -36,67 +23,80 @@ def cb_tag_image(img_path, selected_cat, index_val, path_o): base_name = f"{selected_cat}_{index_val:03d}" new_name = f"{base_name}{ext}" - # --- COLLISION DETECTION --- - # 1. Check Staging DB + # Collision Detection staged = SorterEngine.get_staged_data() - # Get all names currently staged for this category staged_names = {v['name'] for v in staged.values() if v['cat'] == selected_cat} - # 2. Check Hard Drive dest_path = os.path.join(path_o, selected_cat, new_name) - collision = False suffix = 1 - # Loop until we find a free name while new_name in staged_names or os.path.exists(dest_path): collision = True new_name = f"{base_name}_{suffix}{ext}" dest_path = os.path.join(path_o, selected_cat, new_name) suffix += 1 - # --- SAVE --- SorterEngine.stage_image(img_path, selected_cat, new_name) if collision: - st.toast(f"⚠️ Conflict! Saved as variant: {new_name}", icon="🔀") - - # REMOVED: st.session_state.t5_next_index += 1 - # The numbers in the input boxes will now stay static. + st.toast(f"⚠️ Conflict! Saved as: {new_name}", icon="🔀") def cb_untag_image(img_path): SorterEngine.clear_staged_item(img_path) def cb_delete_image(img_path): SorterEngine.delete_to_trash(img_path) - trigger_refresh() # Force re-scan so the image disappears from the list + trigger_refresh() def cb_apply_batch(current_batch, path_o, cleanup_mode, operation): SorterEngine.commit_batch(current_batch, path_o, cleanup_mode, operation) - trigger_refresh() # Force re-scan to remove moved files + trigger_refresh() def cb_apply_global(path_o, cleanup_mode, operation, path_s): SorterEngine.commit_global(path_o, cleanup_mode, operation, source_root=path_s) - trigger_refresh() # Force re-scan + trigger_refresh() def cb_change_page(delta): if 't5_page' not in st.session_state: st.session_state.t5_page = 0 st.session_state.t5_page += delta - # No trigger_refresh() here -> This is why page turning is now instant! -def cb_jump_page(k): - val = st.session_state[k] - st.session_state.t5_page = val - 1 +def cb_set_page(page_idx): + st.session_state.t5_page = page_idx # ========================================== -# 3. FRAGMENTS (Sidebar, Grid, Batch) +# 2. CACHING & DATA LOADING # ========================================== -# ... (Sidebar code remains exactly the same) ... + +@st.cache_data(show_spinner=False) +def get_cached_images(path, mutation_id): + """Scans folder. mutation_id forces refresh.""" + return SorterEngine.get_images(path, recursive=True) + +@st.cache_data(show_spinner=False, max_entries=2000) +def get_cached_thumbnail(path, quality, target_size, mtime): + """Loads and compresses thumbnail.""" + return SorterEngine.compress_for_web(path, quality, target_size) + +@st.dialog("🔍 High-Res Inspection", width="large") +def view_high_res(img_path): + """Modal for full resolution inspection.""" + img_data = SorterEngine.compress_for_web(img_path, quality=90, target_size=None) + if img_data: + st.image(img_data, use_container_width=True) + st.caption(f"Filename: {os.path.basename(img_path)}") + + +# ========================================== +# 3. FRAGMENTS +# ========================================== + @st.fragment def render_sidebar_content(): st.divider() st.subheader("🏷️ Category Manager") + cats = SorterEngine.get_categories() processed_cats = [] last_char = "" @@ -116,6 +116,18 @@ def render_sidebar_content(): selection = st.radio("Active Tag", processed_cats, key="t5_radio_select") if not selection.startswith("---"): st.session_state.t5_active_cat = selection + # Manual Index Control (Sidebar Backup) + st.caption("Tagging Settings") + c_num1, c_num2 = st.columns([3, 1], vertical_alignment="bottom") + if "t5_next_index" not in st.session_state: st.session_state.t5_next_index = 1 + c_num1.number_input("Next Number #", min_value=1, step=1, key="t5_next_index") + if c_num2.button("🔄", help="Auto-detect next number"): + staged = SorterEngine.get_staged_data() + current_cat = st.session_state.t5_active_cat + count = len([v for v in staged.values() if v['cat'] == current_cat]) + st.session_state.t5_next_index = count + 1 + st.rerun() + st.divider() tab_add, tab_edit = st.tabs(["➕ Add", "✏️ Edit"]) with tab_add: @@ -139,57 +151,74 @@ def render_sidebar_content(): if st.button("🗑️ Delete", key=f"del_cat_{target_cat}", type="primary", use_container_width=True): SorterEngine.delete_category(target_cat) st.rerun() - else: - st.info("Select a valid category to edit.") -@st.dialog("🔍 High-Res Inspection", width="large") -def view_high_res(img_path): - """ - Opens a modal and loads the ORIGINAL size image on demand. - We still compress to WebP (q=90) to ensure it sends fast, - but we do NOT resize the dimensions. - """ - # Load with target_size=None to keep original dimensions - # Quality=90 for high fidelity - img_data = SorterEngine.compress_for_web(img_path, quality=90, target_size=None) - - if img_data: - st.image(img_data, use_container_width=True) - st.caption(f"Filename: {os.path.basename(img_path)}") - else: - st.error("Could not load full resolution image.") - -# ... (Gallery Grid code remains exactly the same) ... -# --- UPDATED CACHE FUNCTION --- -@st.cache_data(show_spinner=False, max_entries=2000) -def get_cached_thumbnail(path, quality, target_size, mtime): - # We pass the dynamic target_size here - return SorterEngine.compress_for_web(path, quality, target_size) - -# --- UPDATED GALLERY FRAGMENT --- @st.fragment -def render_gallery_grid(current_batch, quality, grid_cols, path_o): # <--- 1. Added path_o +def render_pagination_carousel(key_suffix, total_pages, all_images, page_size): + """New Carousel with Slider and Green Indicators.""" + current_page = st.session_state.t5_page + if total_pages <= 1: return + + # 1. Get Tagged Pages + tagged_pages_set = SorterEngine.get_tagged_page_indices(all_images, page_size) + + # 2. Rapid Seeker Slider + new_page = st.slider( + "Rapid Navigation", 0, total_pages - 1, current_page, + key=f"slider_{key_suffix}", label_visibility="collapsed" + ) + if new_page != current_page: + st.session_state.t5_page = new_page + st.rerun() + + # 3. Button Window Logic + window_radius = 2 + start_p = max(0, current_page - window_radius) + end_p = min(total_pages, current_page + window_radius + 1) + + if current_page < window_radius: end_p = min(total_pages, 5) + elif current_page > total_pages - window_radius - 1: start_p = max(0, total_pages - 5) + + num_page_buttons = end_p - start_p + if num_page_buttons < 1: return + + # Render Buttons + cols = st.columns([1] + [1] * num_page_buttons + [1]) + + # Prev + with cols[0]: + st.button("◀", disabled=(current_page == 0), on_click=cb_change_page, args=(-1,), key=f"prev_{key_suffix}", use_container_width=True) + + # Numbered Buttons + for i, p_idx in enumerate(range(start_p, end_p)): + with cols[i + 1]: + label = str(p_idx + 1) + if p_idx in tagged_pages_set: label += " 🟢" + btn_type = "primary" if p_idx == current_page else "secondary" + st.button(label, type=btn_type, key=f"btn_p{p_idx}_{key_suffix}", use_container_width=True, on_click=cb_set_page, args=(p_idx,)) + + # Next + with cols[-1]: + st.button("▶", disabled=(current_page >= total_pages - 1), on_click=cb_change_page, args=(1,), key=f"next_{key_suffix}", use_container_width=True) + + +@st.fragment +def render_gallery_grid(current_batch, quality, grid_cols, path_o): + """Grid with Zoom, Parallel Load, and Manual Indexing.""" staged = SorterEngine.get_staged_data() history = SorterEngine.get_processed_log() selected_cat = st.session_state.get("t5_active_cat", "Default") tagging_disabled = selected_cat.startswith("---") - # 2. Ensure global counter exists (default to 1) if "t5_next_index" not in st.session_state: st.session_state.t5_next_index = 1 - - # 3. Smart Resolution (Wide screen assumption) target_size = int(2400 / grid_cols) - # 4. Parallel Load (16 threads for WebP) - import concurrent.futures + # Parallel Load batch_cache = {} - def fetch_one(p): try: mtime = os.path.getmtime(p) return p, get_cached_thumbnail(p, quality, target_size, mtime) - except: - return p, None + except: return p, None with concurrent.futures.ThreadPoolExecutor(max_workers=16) as executor: future_to_path = {executor.submit(fetch_one, p): p for p in current_batch} @@ -197,7 +226,6 @@ def render_gallery_grid(current_batch, quality, grid_cols, path_o): # <--- 1. Ad p, data = future.result() batch_cache[p] = data - # 5. Render Grid cols = st.columns(grid_cols) for idx, img_path in enumerate(current_batch): unique_key = f"frag_{os.path.basename(img_path)}" @@ -206,91 +234,66 @@ def render_gallery_grid(current_batch, quality, grid_cols, path_o): # <--- 1. Ad is_processed = img_path in history with st.container(border=True): - # Header: [Name] [Zoom] [Delete] + # Header c_name, c_zoom, c_del = st.columns([4, 1, 1]) c_name.caption(os.path.basename(img_path)[:10]) - - if c_zoom.button("🔍", key=f"zoom_{unique_key}"): - view_high_res(img_path) - + if c_zoom.button("🔍", key=f"zoom_{unique_key}"): view_high_res(img_path) c_del.button("❌", key=f"del_{unique_key}", on_click=cb_delete_image, args=(img_path,)) - # Status Banners - if is_staged: - st.success(f"🏷️ {staged[img_path]['cat']}") - elif is_processed: - st.info(f"✅ {history[img_path]['action']}") + # Status + if is_staged: st.success(f"🏷️ {staged[img_path]['cat']}") + elif is_processed: st.info(f"✅ {history[img_path]['action']}") - # Image (Cached) + # Image img_data = batch_cache.get(img_path) - if img_data: - st.image(img_data, use_container_width=True) + if img_data: st.image(img_data, use_container_width=True) - # Action Area + # Actions if not is_staged: - # 6. Split Row: [Idx Input] [Tag Button] c_idx, c_tag = st.columns([1, 2], vertical_alignment="bottom") + card_index = c_idx.number_input("Idx", min_value=1, step=1, + value=st.session_state.t5_next_index, label_visibility="collapsed", key=f"idx_{unique_key}") - # Manual Override Box (Defaults to global session value) - card_index = c_idx.number_input( - "Idx", - min_value=1, step=1, - value=st.session_state.t5_next_index, - label_visibility="collapsed", - key=f"idx_{unique_key}" - ) - - # Tag Button (Passes path_o for conflict check) - c_tag.button( - "Tag", - key=f"tag_{unique_key}", - disabled=tagging_disabled, - use_container_width=True, - on_click=cb_tag_image, - # Passing card_index + path_o is vital here - args=(img_path, selected_cat, card_index, path_o) - ) + c_tag.button("Tag", key=f"tag_{unique_key}", disabled=tagging_disabled, + use_container_width=True, on_click=cb_tag_image, + args=(img_path, selected_cat, card_index, path_o)) else: st.button("Untag", key=f"untag_{unique_key}", use_container_width=True, on_click=cb_untag_image, args=(img_path,)) -# ... (Batch Actions code remains exactly the same) ... + @st.fragment def render_batch_actions(current_batch, path_o, page_num, path_s): st.write(f"### 🚀 Processing Actions") st.caption("Settings apply to both Page and Global actions.") - c_set1, c_set2 = st.columns(2) - - # CHANGED: "Copy" is now first, making it the default + # Default is Copy op_mode = c_set1.radio("Tagged Files:", ["Copy", "Move"], horizontal=True, key="t5_op_mode") - cleanup = c_set2.radio("Untagged Files:", ["Keep", "Move to Unused", "Delete"], horizontal=True, key="t5_cleanup_mode") st.divider() - c_btn1, c_btn2 = st.columns(2) - # BUTTON 1: APPLY PAGE if c_btn1.button(f"APPLY PAGE {page_num}", type="secondary", use_container_width=True, on_click=cb_apply_batch, args=(current_batch, path_o, cleanup, op_mode)): st.toast(f"Page {page_num} Applied!") st.rerun() - # BUTTON 2: APPLY GLOBAL if c_btn2.button("APPLY ALL (GLOBAL)", type="primary", use_container_width=True, - help="Process ALL tagged files across all pages.", + help="Process ALL tagged files.", on_click=cb_apply_global, args=(path_o, cleanup, op_mode, path_s)): st.toast("Global Apply Complete!") st.rerun() + # ========================================== -# 4. MAIN RENDERER +# 4. MAIN RENDER # ========================================== + def render(quality, profile_name): st.subheader("🖼️ Gallery Staging Sorter") - # Init Mutation ID (This triggers the scanner cache refresh) + # Init State if 't5_file_id' not in st.session_state: st.session_state.t5_file_id = 0 if 't5_page' not in st.session_state: st.session_state.t5_page = 0 @@ -303,7 +306,6 @@ def render(quality, profile_name): if path_s != p_data.get("tab5_source") or path_o != p_data.get("tab5_out"): if st.button("💾 Save Settings"): SorterEngine.save_tab_paths(profile_name, t5_s=path_s, t5_o=path_o) - # Saving settings might mean new folder, so we trigger refresh trigger_refresh() st.rerun() @@ -317,14 +319,13 @@ def render(quality, profile_name): page_size = c_v1.slider("Images per Page", 12, 100, 24, 4) grid_cols = c_v2.slider("Grid Columns", 2, 8, 4) - # --- USING CACHED LOADER --- - # We pass the mutation ID. If ID is same as last run, scan is SKIPPED. + # Load Files (Cached) all_images = get_cached_images(path_s, st.session_state.t5_file_id) - if not all_images: st.info("No images found.") return + # Pagination Math total_items = len(all_images) total_pages = math.ceil(total_items / page_size) if st.session_state.t5_page >= total_pages: st.session_state.t5_page = max(0, total_pages - 1) @@ -334,98 +335,14 @@ def render(quality, profile_name): end_idx = start_idx + page_size current_batch = all_images[start_idx:end_idx] - # Place this helper inside tab_gallery_sorter.py (or keep it if you have the old one) -def cb_set_page(page_idx): - st.session_state.t5_page = page_idx - -def render_pagination_carousel(key_suffix, total_pages, all_images, page_size): - """ - Renders a 'Carousel' style pagination with a slider for fast seeking - and buttons for precise selection with status indicators. - """ - current_page = st.session_state.t5_page - - # 1. CALCULATE TAGGED PAGES (For the Green Indicator) - # We do this once per render - tagged_pages_set = SorterEngine.get_tagged_page_indices(all_images, page_size) - - # --- A. RAPID SEEKER SLIDER (Debounced) --- - # Streamlit sliders only rerun the script on mouse release. - # This acts as your "wait a bit" logic. - new_page = st.slider( - "Rapid Navigation", - 0, total_pages - 1, current_page, - key=f"slider_{key_suffix}", - label_visibility="collapsed" - ) - - # If slider moved, update state and rerun - if new_page != current_page: - st.session_state.t5_page = new_page - st.rerun() - - # --- B. BUTTON CAROUSEL --- - # We want to show a window of pages: [Prev] .. [p-2] [p-1] [P] [p+1] [p+2] .. [Next] - - # Define window size (how many numbered buttons to show) - window_radius = 2 - start_p = max(0, current_page - window_radius) - end_p = min(total_pages, current_page + window_radius + 1) - - # Adjust window if we are near the start or end to keep number of buttons constant - if current_page < window_radius: - end_p = min(total_pages, 5) - elif current_page > total_pages - window_radius - 1: - start_p = max(0, total_pages - 5) - - # Layout: Prev + (Window Buttons) + Next - # Total columns = (end_p - start_p) + 2 buttons - num_page_buttons = end_p - start_p - cols = st.columns([1] + [1] * num_page_buttons + [1]) - - # 1. PREV BUTTON - with cols[0]: - st.button("◀", disabled=(current_page == 0), - on_click=cb_change_page, args=(-1,), - key=f"prev_{key_suffix}", use_container_width=True) - - # 2. PAGE NUMBER BUTTONS - for i, p_idx in enumerate(range(start_p, end_p)): - col_idx = i + 1 - with cols[col_idx]: - # Label Logic: Add 🟢 if tagged - label = str(p_idx + 1) - if p_idx in tagged_pages_set: - label += " 🟢" - - # Highlight current page using type="primary" - is_active = (p_idx == current_page) - btn_type = "primary" if is_active else "secondary" - - st.button(label, - type=btn_type, - key=f"btn_p{p_idx}_{key_suffix}", - use_container_width=True, - on_click=cb_set_page, args=(p_idx,)) - - # 3. NEXT BUTTON - with cols[-1]: - st.button("▶", disabled=(current_page >= total_pages - 1), - on_click=cb_change_page, args=(1,), - key=f"next_{key_suffix}", use_container_width=True) - - # --- RENDER PAGE --- + # --- RENDER UI --- st.divider() - - # Replaces: nav_controls("top") render_pagination_carousel("top", total_pages, all_images, page_size) - # ... render_gallery_grid call ... render_gallery_grid(current_batch, quality, grid_cols, path_o) st.divider() - - # Replaces: nav_controls("bottom") render_pagination_carousel("bot", total_pages, all_images, page_size) - st.divider() \ No newline at end of file + st.divider() + render_batch_actions(current_batch, path_o, st.session_state.t5_page + 1, path_s) \ No newline at end of file From a6314cadd9957e93c594af52db953bc7d59a722d Mon Sep 17 00:00:00 2001 From: Ethanfel Date: Mon, 19 Jan 2026 15:46:19 +0100 Subject: [PATCH 06/11] Update tab_gallery_sorter.py --- tab_gallery_sorter.py | 83 +++++++++++++++++++++++++++++++------------ 1 file changed, 60 insertions(+), 23 deletions(-) diff --git a/tab_gallery_sorter.py b/tab_gallery_sorter.py index 523fa95..13b3c87 100644 --- a/tab_gallery_sorter.py +++ b/tab_gallery_sorter.py @@ -64,6 +64,16 @@ def cb_change_page(delta): def cb_set_page(page_idx): st.session_state.t5_page = page_idx +def cb_slider_change(key): + """ + Updates the page number from the slider. + Adjusts for 1-based display (Slider=1 -> Page=0). + """ + # Get the value from the widget + val = st.session_state[key] + # Update the global page index (0-based) + st.session_state.t5_page = val - 1 + # ========================================== # 2. CACHING & DATA LOADING @@ -152,54 +162,81 @@ def render_sidebar_content(): SorterEngine.delete_category(target_cat) st.rerun() -@st.fragment +# NOTE: Do NOT use @st.fragment here. +# Navigation controls must trigger a full app rerun to load the new batch of images. def render_pagination_carousel(key_suffix, total_pages, all_images, page_size): - """New Carousel with Slider and Green Indicators.""" - current_page = st.session_state.t5_page - if total_pages <= 1: return + """ + Renders pagination with 1-based indexing and smooth callbacks. + """ + # Safety Check + if total_pages <= 1: + return - # 1. Get Tagged Pages + current_page = st.session_state.t5_page + + # 1. Get Tagged Pages (for the Green Dot) tagged_pages_set = SorterEngine.get_tagged_page_indices(all_images, page_size) - # 2. Rapid Seeker Slider - new_page = st.slider( - "Rapid Navigation", 0, total_pages - 1, current_page, - key=f"slider_{key_suffix}", label_visibility="collapsed" + # 2. Rapid Seeker Slider (1-BASED) + # We set min=1 and max=total_pages so it looks human-readable. + # The callback 'cb_slider_change' handles the -1 conversion. + st.slider( + "Rapid Navigation", + min_value=1, + max_value=total_pages, + value=current_page + 1, + step=1, + key=f"slider_{key_suffix}", + label_visibility="collapsed", + on_change=cb_slider_change, args=(f"slider_{key_suffix}",) ) - if new_page != current_page: - st.session_state.t5_page = new_page - st.rerun() # 3. Button Window Logic window_radius = 2 start_p = max(0, current_page - window_radius) end_p = min(total_pages, current_page + window_radius + 1) - if current_page < window_radius: end_p = min(total_pages, 5) - elif current_page > total_pages - window_radius - 1: start_p = max(0, total_pages - 5) + # Keep the window width constant near edges + if current_page < window_radius: + end_p = min(total_pages, 5) + elif current_page > total_pages - window_radius - 1: + start_p = max(0, total_pages - 5) num_page_buttons = end_p - start_p if num_page_buttons < 1: return - # Render Buttons + # 4. Render Buttons cols = st.columns([1] + [1] * num_page_buttons + [1]) - # Prev + # PREV with cols[0]: - st.button("◀", disabled=(current_page == 0), on_click=cb_change_page, args=(-1,), key=f"prev_{key_suffix}", use_container_width=True) + st.button("◀", disabled=(current_page == 0), + on_click=cb_change_page, args=(-1,), + key=f"prev_{key_suffix}", use_container_width=True) - # Numbered Buttons + # NUMBERED BUTTONS (1-BASED LABELS) for i, p_idx in enumerate(range(start_p, end_p)): with cols[i + 1]: + # Human readable label (Page 0 -> "1") label = str(p_idx + 1) - if p_idx in tagged_pages_set: label += " 🟢" + + # Green Dot Indicator + if p_idx in tagged_pages_set: + label += " 🟢" + + # Highlight Active Page btn_type = "primary" if p_idx == current_page else "secondary" - st.button(label, type=btn_type, key=f"btn_p{p_idx}_{key_suffix}", use_container_width=True, on_click=cb_set_page, args=(p_idx,)) + + st.button(label, type=btn_type, + key=f"btn_p{p_idx}_{key_suffix}", + use_container_width=True, + on_click=cb_set_page, args=(p_idx,)) - # Next + # NEXT with cols[-1]: - st.button("▶", disabled=(current_page >= total_pages - 1), on_click=cb_change_page, args=(1,), key=f"next_{key_suffix}", use_container_width=True) - + st.button("▶", disabled=(current_page >= total_pages - 1), + on_click=cb_change_page, args=(1,), + key=f"next_{key_suffix}", use_container_width=True) @st.fragment def render_gallery_grid(current_batch, quality, grid_cols, path_o): From 04a29d74249c984efbb6ea792b4058f1c63a9caf Mon Sep 17 00:00:00 2001 From: Ethanfel Date: Mon, 19 Jan 2026 16:03:30 +0100 Subject: [PATCH 07/11] Update tab_gallery_sorter.py --- tab_gallery_sorter.py | 91 +++++++++++++++++++++++++++++++++++++------ 1 file changed, 80 insertions(+), 11 deletions(-) diff --git a/tab_gallery_sorter.py b/tab_gallery_sorter.py index 13b3c87..f7aa396 100644 --- a/tab_gallery_sorter.py +++ b/tab_gallery_sorter.py @@ -103,10 +103,11 @@ def view_high_res(img_path): # ========================================== @st.fragment -def render_sidebar_content(): +def render_sidebar_content(path_o): # <--- NOTE: Added path_o argument st.divider() st.subheader("🏷️ Category Manager") + # --- 1. PREPARE CATEGORIES --- cats = SorterEngine.get_categories() processed_cats = [] last_char = "" @@ -118,27 +119,77 @@ def render_sidebar_content(): processed_cats.append(cat) last_char = current_char + # --- 2. STATE SYNC --- if "t5_active_cat" not in st.session_state: st.session_state.t5_active_cat = cats[0] if cats else "Default" - current_selection = st.session_state.t5_active_cat - if not current_selection.startswith("---") and current_selection not in cats: - st.session_state.t5_active_cat = cats[0] if cats else "Default" + current_cat = st.session_state.t5_active_cat + + # --- 3. VISUAL NUMBER GRID (1-25) --- + # Only show if a valid category is selected + if current_cat and not current_cat.startswith("---"): + st.caption(f"Map: **{current_cat}**") + + # A. Find Used Indices (Staging + Disk) + used_indices = set() + + # Check Staging + staged = SorterEngine.get_staged_data() + for v in staged.values(): + if v['cat'] == current_cat: + # Extract number from "Category_005.jpg" + try: + parts = v['name'].rsplit('_', 1) # ["Category", "005.jpg"] + num_part = parts[1].split('.')[0] # "005" + used_indices.add(int(num_part)) + except: pass + # Check Disk + cat_path = os.path.join(path_o, current_cat) + if os.path.exists(cat_path): + for f in os.listdir(cat_path): + if f.startswith(current_cat) and "_" in f: + try: + parts = f.rsplit('_', 1) + num_part = parts[1].split('.')[0] + used_indices.add(int(num_part)) + except: pass + + # B. Render 5x5 Grid + # We use a helper to update the index when clicked + def set_index(i): + st.session_state.t5_next_index = i + + grid_cols = st.columns(5, gap="small") + for i in range(1, 26): + is_used = i in used_indices + btn_type = "primary" if is_used else "secondary" + + with grid_cols[(i-1) % 5]: + # If used, it's green. If clicked, it sets the index. + st.button(f"{i}", key=f"grid_{i}", type=btn_type, + use_container_width=True, + on_click=set_index, args=(i,)) + st.divider() + + # --- 4. RADIO SELECTION --- selection = st.radio("Active Tag", processed_cats, key="t5_radio_select") if not selection.startswith("---"): st.session_state.t5_active_cat = selection - # Manual Index Control (Sidebar Backup) + # --- 5. MANUAL INPUT --- st.caption("Tagging Settings") c_num1, c_num2 = st.columns([3, 1], vertical_alignment="bottom") if "t5_next_index" not in st.session_state: st.session_state.t5_next_index = 1 + c_num1.number_input("Next Number #", min_value=1, step=1, key="t5_next_index") + if c_num2.button("🔄", help="Auto-detect next number"): - staged = SorterEngine.get_staged_data() - current_cat = st.session_state.t5_active_cat - count = len([v for v in staged.values() if v['cat'] == current_cat]) - st.session_state.t5_next_index = count + 1 + # Simple auto-detect: Max used + 1 + next_val = max(used_indices) + 1 if used_indices else 1 + st.session_state.t5_next_index = next_val st.rerun() st.divider() + + # ... (Add/Edit Tabs - Keep existing code) ... tab_add, tab_edit = st.tabs(["➕ Add", "✏️ Edit"]) with tab_add: c1, c2 = st.columns([3, 1]) @@ -148,6 +199,7 @@ def render_sidebar_content(): SorterEngine.add_category(new_cat) st.rerun() with tab_edit: + # (Existing Edit logic) target_cat = st.session_state.t5_active_cat if target_cat and not target_cat.startswith("---") and target_cat in cats: st.caption(f"Editing: **{target_cat}**") @@ -295,7 +347,24 @@ def render_gallery_grid(current_batch, quality, grid_cols, path_o): use_container_width=True, on_click=cb_tag_image, args=(img_path, selected_cat, card_index, path_o)) else: - st.button("Untag", key=f"untag_{unique_key}", use_container_width=True, + # CASE: Image is STAGED + # We want to show "Untag (#5)" + + # 1. Get the current filename from staging data + staged_name = staged[img_path]['name'] # e.g., "Category_005.jpg" + + # 2. Extract the number + untag_label = "Untag" + try: + # Split by underscore, grab the last part, remove extension + parts = staged_name.rsplit('_', 1) + if len(parts) > 1: + num_str = parts[1].split('.')[0] # "005" + untag_label = f"Untag (#{int(num_str)})" + except: + pass + + st.button(untag_label, key=f"untag_{unique_key}", use_container_width=True, on_click=cb_untag_image, args=(img_path,)) @@ -349,7 +418,7 @@ def render(quality, profile_name): if not os.path.exists(path_s): return with st.sidebar: - render_sidebar_content() + render_sidebar_content(path_o) with st.expander("👀 View Settings"): c_v1, c_v2 = st.columns(2) From e4b126075d023fa7648562c89248172a5c4c0eae Mon Sep 17 00:00:00 2001 From: Ethanfel Date: Mon, 19 Jan 2026 16:10:27 +0100 Subject: [PATCH 08/11] Update tab_gallery_sorter.py --- tab_gallery_sorter.py | 72 ++++++++++++++++++++++++++++--------------- 1 file changed, 48 insertions(+), 24 deletions(-) diff --git a/tab_gallery_sorter.py b/tab_gallery_sorter.py index f7aa396..9cacd00 100644 --- a/tab_gallery_sorter.py +++ b/tab_gallery_sorter.py @@ -97,13 +97,27 @@ def view_high_res(img_path): st.image(img_data, use_container_width=True) st.caption(f"Filename: {os.path.basename(img_path)}") +@st.dialog("🖼️ Tag Preview", width="large") +def view_tag_preview(img_path, title): + """Shows the image associated with a number in the grid.""" + st.subheader(title) + + # Load image (Fast WebP) + # We use target_size=800 for a good quality preview + img_data = SorterEngine.compress_for_web(img_path, quality=80, target_size=800) + + if img_data: + st.image(img_data, use_container_width=True) + st.caption(f"Source: {img_path}") + else: + st.error(f"Could not load image: {img_path}") # ========================================== # 3. FRAGMENTS # ========================================== @st.fragment -def render_sidebar_content(path_o): # <--- NOTE: Added path_o argument +def render_sidebar_content(path_o): st.divider() st.subheader("🏷️ Category Manager") @@ -124,25 +138,26 @@ def render_sidebar_content(path_o): # <--- NOTE: Added path_o argument current_cat = st.session_state.t5_active_cat # --- 3. VISUAL NUMBER GRID (1-25) --- - # Only show if a valid category is selected if current_cat and not current_cat.startswith("---"): st.caption(f"Map: **{current_cat}**") - # A. Find Used Indices (Staging + Disk) - used_indices = set() + # A. Build Index Map: { number: image_path } + # We check both Staging (Memory) and Output (Disk) + index_map = {} - # Check Staging + # 1. Check Staging staged = SorterEngine.get_staged_data() - for v in staged.values(): - if v['cat'] == current_cat: - # Extract number from "Category_005.jpg" + for orig_path, info in staged.items(): + if info['cat'] == current_cat: try: - parts = v['name'].rsplit('_', 1) # ["Category", "005.jpg"] - num_part = parts[1].split('.')[0] # "005" - used_indices.add(int(num_part)) + # Parse "Category_005.jpg" -> 5 + parts = info['name'].rsplit('_', 1) + num_part = parts[1].split('.')[0] + idx = int(num_part) + index_map[idx] = orig_path # Store ORIGINAL source path for preview except: pass - # Check Disk + # 2. Check Disk (Output Folder) cat_path = os.path.join(path_o, current_cat) if os.path.exists(cat_path): for f in os.listdir(cat_path): @@ -150,24 +165,33 @@ def render_sidebar_content(path_o): # <--- NOTE: Added path_o argument try: parts = f.rsplit('_', 1) num_part = parts[1].split('.')[0] - used_indices.add(int(num_part)) + idx = int(num_part) + # Only add if not in staging (Staging overrides disk visually) + if idx not in index_map: + index_map[idx] = os.path.join(cat_path, f) except: pass # B. Render 5x5 Grid - # We use a helper to update the index when clicked - def set_index(i): - st.session_state.t5_next_index = i - grid_cols = st.columns(5, gap="small") for i in range(1, 26): - is_used = i in used_indices + is_used = i in index_map btn_type = "primary" if is_used else "secondary" with grid_cols[(i-1) % 5]: - # If used, it's green. If clicked, it sets the index. - st.button(f"{i}", key=f"grid_{i}", type=btn_type, - use_container_width=True, - on_click=set_index, args=(i,)) + # We handle the click logic manually here instead of a callback + # to trigger the dialog properly. + if st.button(f"{i}", key=f"grid_{i}", type=btn_type, use_container_width=True): + # 1. Set the Index + st.session_state.t5_next_index = i + + # 2. If image exists, SHOW DIALOG + if is_used: + file_path = index_map[i] + view_tag_preview(file_path, f"{current_cat} #{i}") + else: + # Optional: Just toast that it's set + st.toast(f"Next Index set to #{i}") + st.divider() # --- 4. RADIO SELECTION --- @@ -182,7 +206,8 @@ def render_sidebar_content(path_o): # <--- NOTE: Added path_o argument c_num1.number_input("Next Number #", min_value=1, step=1, key="t5_next_index") if c_num2.button("🔄", help="Auto-detect next number"): - # Simple auto-detect: Max used + 1 + # Max used + 1 + used_indices = index_map.keys() next_val = max(used_indices) + 1 if used_indices else 1 st.session_state.t5_next_index = next_val st.rerun() @@ -199,7 +224,6 @@ def render_sidebar_content(path_o): # <--- NOTE: Added path_o argument SorterEngine.add_category(new_cat) st.rerun() with tab_edit: - # (Existing Edit logic) target_cat = st.session_state.t5_active_cat if target_cat and not target_cat.startswith("---") and target_cat in cats: st.caption(f"Editing: **{target_cat}**") From 13818737e21f3c23ce283eb454ae91fdb830025c Mon Sep 17 00:00:00 2001 From: Ethanfel Date: Mon, 19 Jan 2026 16:14:17 +0100 Subject: [PATCH 09/11] Update tab_gallery_sorter.py --- tab_gallery_sorter.py | 39 +++++++++++++++++++-------------------- 1 file changed, 19 insertions(+), 20 deletions(-) diff --git a/tab_gallery_sorter.py b/tab_gallery_sorter.py index 9cacd00..c9949f9 100644 --- a/tab_gallery_sorter.py +++ b/tab_gallery_sorter.py @@ -133,8 +133,19 @@ def render_sidebar_content(path_o): processed_cats.append(cat) last_char = current_char - # --- 2. STATE SYNC --- - if "t5_active_cat" not in st.session_state: st.session_state.t5_active_cat = cats[0] if cats else "Default" + # --- 2. INSTANT STATE SYNC (The Fix) --- + # We check the radio widget's state ('t5_radio_select') BEFORE rendering the grid. + # This ensures the grid sees the new selection immediately. + if "t5_radio_select" in st.session_state: + new_selection = st.session_state.t5_radio_select + # Only update if it's a valid category (ignore separators) + if not new_selection.startswith("---"): + st.session_state.t5_active_cat = new_selection + + # Ensure default exists + if "t5_active_cat" not in st.session_state: + st.session_state.t5_active_cat = cats[0] if cats else "Default" + current_cat = st.session_state.t5_active_cat # --- 3. VISUAL NUMBER GRID (1-25) --- @@ -142,22 +153,19 @@ def render_sidebar_content(path_o): st.caption(f"Map: **{current_cat}**") # A. Build Index Map: { number: image_path } - # We check both Staging (Memory) and Output (Disk) index_map = {} - # 1. Check Staging + # Check Staging staged = SorterEngine.get_staged_data() for orig_path, info in staged.items(): if info['cat'] == current_cat: try: - # Parse "Category_005.jpg" -> 5 parts = info['name'].rsplit('_', 1) num_part = parts[1].split('.')[0] - idx = int(num_part) - index_map[idx] = orig_path # Store ORIGINAL source path for preview + index_map[int(num_part)] = orig_path except: pass - # 2. Check Disk (Output Folder) + # Check Disk cat_path = os.path.join(path_o, current_cat) if os.path.exists(cat_path): for f in os.listdir(cat_path): @@ -166,37 +174,29 @@ def render_sidebar_content(path_o): parts = f.rsplit('_', 1) num_part = parts[1].split('.')[0] idx = int(num_part) - # Only add if not in staging (Staging overrides disk visually) if idx not in index_map: index_map[idx] = os.path.join(cat_path, f) except: pass - # B. Render 5x5 Grid + # B. Render Grid grid_cols = st.columns(5, gap="small") for i in range(1, 26): is_used = i in index_map btn_type = "primary" if is_used else "secondary" with grid_cols[(i-1) % 5]: - # We handle the click logic manually here instead of a callback - # to trigger the dialog properly. if st.button(f"{i}", key=f"grid_{i}", type=btn_type, use_container_width=True): - # 1. Set the Index st.session_state.t5_next_index = i - - # 2. If image exists, SHOW DIALOG if is_used: file_path = index_map[i] view_tag_preview(file_path, f"{current_cat} #{i}") else: - # Optional: Just toast that it's set st.toast(f"Next Index set to #{i}") - st.divider() # --- 4. RADIO SELECTION --- - selection = st.radio("Active Tag", processed_cats, key="t5_radio_select") - if not selection.startswith("---"): st.session_state.t5_active_cat = selection + # We render the radio here, but its value was already used above! + st.radio("Active Tag", processed_cats, key="t5_radio_select") # --- 5. MANUAL INPUT --- st.caption("Tagging Settings") @@ -206,7 +206,6 @@ def render_sidebar_content(path_o): c_num1.number_input("Next Number #", min_value=1, step=1, key="t5_next_index") if c_num2.button("🔄", help="Auto-detect next number"): - # Max used + 1 used_indices = index_map.keys() next_val = max(used_indices) + 1 if used_indices else 1 st.session_state.t5_next_index = next_val From 40453dad949c50800210da94baf1acda17c25496 Mon Sep 17 00:00:00 2001 From: Ethanfel Date: Mon, 19 Jan 2026 16:32:35 +0100 Subject: [PATCH 10/11] Update tab_gallery_sorter.py --- tab_gallery_sorter.py | 97 ++++++++++++++++++++++++------------------- 1 file changed, 55 insertions(+), 42 deletions(-) diff --git a/tab_gallery_sorter.py b/tab_gallery_sorter.py index c9949f9..3eb94f6 100644 --- a/tab_gallery_sorter.py +++ b/tab_gallery_sorter.py @@ -65,13 +65,7 @@ def cb_set_page(page_idx): st.session_state.t5_page = page_idx def cb_slider_change(key): - """ - Updates the page number from the slider. - Adjusts for 1-based display (Slider=1 -> Page=0). - """ - # Get the value from the widget val = st.session_state[key] - # Update the global page index (0-based) st.session_state.t5_page = val - 1 @@ -112,6 +106,22 @@ def view_tag_preview(img_path, title): else: st.error(f"Could not load image: {img_path}") +@st.cache_data(show_spinner=False) +def get_cached_green_dots(all_images, page_size, staged_keys): + """ + Calculates which pages have tags. + Cached based on the specific keys in the staging area. + """ + # We reconstruct the set of staged keys from the frozenset + staged_set = set(staged_keys) + tagged_pages = set() + + # Efficient O(N) scan ONLY when tagging changes + for idx, img_path in enumerate(all_images): + if img_path in staged_set: + tagged_pages.add(idx // page_size) + + return tagged_pages # ========================================== # 3. FRAGMENTS # ========================================== @@ -239,67 +249,58 @@ def render_sidebar_content(path_o): # NOTE: Do NOT use @st.fragment here. # Navigation controls must trigger a full app rerun to load the new batch of images. -def render_pagination_carousel(key_suffix, total_pages, all_images, page_size): +# CHANGED: Added 'tagged_pages_set' to arguments +def render_pagination_carousel(key_suffix, total_pages, current_page, tagged_pages_set): """ - Renders pagination with 1-based indexing and smooth callbacks. + Renders pagination. No calculation here—just pure UI rendering. """ - # Safety Check - if total_pages <= 1: - return + if total_pages <= 1: return - current_page = st.session_state.t5_page - - # 1. Get Tagged Pages (for the Green Dot) - tagged_pages_set = SorterEngine.get_tagged_page_indices(all_images, page_size) - - # 2. Rapid Seeker Slider (1-BASED) - # We set min=1 and max=total_pages so it looks human-readable. - # The callback 'cb_slider_change' handles the -1 conversion. + # 1. Rapid Seeker Slider (1-BASED) st.slider( "Rapid Navigation", - min_value=1, - max_value=total_pages, - value=current_page + 1, - step=1, - key=f"slider_{key_suffix}", - label_visibility="collapsed", + min_value=1, max_value=total_pages, value=current_page + 1, step=1, + key=f"slider_{key_suffix}", label_visibility="collapsed", on_change=cb_slider_change, args=(f"slider_{key_suffix}",) ) - # 3. Button Window Logic + # 2. Window Logic (Calculate range of buttons to show) window_radius = 2 start_p = max(0, current_page - window_radius) end_p = min(total_pages, current_page + window_radius + 1) - # Keep the window width constant near edges - if current_page < window_radius: + # Adjust window near edges to keep width constant + if current_page < window_radius: end_p = min(total_pages, 5) - elif current_page > total_pages - window_radius - 1: + elif current_page > total_pages - window_radius - 1: start_p = max(0, total_pages - 5) num_page_buttons = end_p - start_p - if num_page_buttons < 1: return + # Safety check if page count is small + if num_page_buttons < 1: + start_p = 0 + end_p = total_pages + num_page_buttons = total_pages - # 4. Render Buttons + # 3. Render Buttons + # We create columns: [Prev] + [1] [2] [3] ... + [Next] cols = st.columns([1] + [1] * num_page_buttons + [1]) - # PREV + # --- PREV BUTTON --- with cols[0]: st.button("◀", disabled=(current_page == 0), on_click=cb_change_page, args=(-1,), key=f"prev_{key_suffix}", use_container_width=True) - # NUMBERED BUTTONS (1-BASED LABELS) + # --- NUMBERED BUTTONS --- for i, p_idx in enumerate(range(start_p, end_p)): with cols[i + 1]: - # Human readable label (Page 0 -> "1") label = str(p_idx + 1) - - # Green Dot Indicator + # Add Green Dot if this page has tagged items if p_idx in tagged_pages_set: label += " 🟢" - # Highlight Active Page + # Highlight Current Page btn_type = "primary" if p_idx == current_page else "secondary" st.button(label, type=btn_type, @@ -307,7 +308,7 @@ def render_pagination_carousel(key_suffix, total_pages, all_images, page_size): use_container_width=True, on_click=cb_set_page, args=(p_idx,)) - # NEXT + # --- NEXT BUTTON --- with cols[-1]: st.button("▶", disabled=(current_page >= total_pages - 1), on_click=cb_change_page, args=(1,), @@ -454,7 +455,7 @@ def render(quality, profile_name): st.info("No images found.") return - # Pagination Math + # Pagination Math total_items = len(all_images) total_pages = math.ceil(total_items / page_size) if st.session_state.t5_page >= total_pages: st.session_state.t5_page = max(0, total_pages - 1) @@ -464,14 +465,26 @@ def render(quality, profile_name): end_idx = start_idx + page_size current_batch = all_images[start_idx:end_idx] - # --- RENDER UI --- + # --- 1. CALCULATE GREEN DOTS ONCE (Optimized) --- + staged_data = SorterEngine.get_staged_data() + # We pass 'frozenset' so the cache works efficiently + green_dots_set = get_cached_green_dots(all_images, page_size, frozenset(staged_data.keys())) + + # --- 2. RENDER UI --- st.divider() - render_pagination_carousel("top", total_pages, all_images, page_size) + + # CORRECTED CALL: Pass 'current_page' and 'green_dots_set' + render_pagination_carousel("top", total_pages, st.session_state.t5_page, green_dots_set) render_gallery_grid(current_batch, quality, grid_cols, path_o) st.divider() - render_pagination_carousel("bot", total_pages, all_images, page_size) + + # CORRECTED CALL + render_pagination_carousel("bot", total_pages, st.session_state.t5_page, green_dots_set) + + st.divider() + render_batch_actions(current_batch, path_o, st.session_state.t5_page + 1, path_s) st.divider() render_batch_actions(current_batch, path_o, st.session_state.t5_page + 1, path_s) \ No newline at end of file From bf845292eef85a250b4bbf12457a1cd1f0469896 Mon Sep 17 00:00:00 2001 From: Ethanfel Date: Mon, 19 Jan 2026 16:46:13 +0100 Subject: [PATCH 11/11] Update tab_gallery_sorter.py --- tab_gallery_sorter.py | 36 +++++++++++++++++++++++------------- 1 file changed, 23 insertions(+), 13 deletions(-) diff --git a/tab_gallery_sorter.py b/tab_gallery_sorter.py index 3eb94f6..628a3fe 100644 --- a/tab_gallery_sorter.py +++ b/tab_gallery_sorter.py @@ -423,41 +423,50 @@ def render_batch_actions(current_batch, path_o, page_num, path_s): def render(quality, profile_name): st.subheader("🖼️ Gallery Staging Sorter") - # Init State + # --- 1. INITIALIZE STATE --- if 't5_file_id' not in st.session_state: st.session_state.t5_file_id = 0 if 't5_page' not in st.session_state: st.session_state.t5_page = 0 + # --- 2. LOAD PROFILES & PATHS --- profiles = SorterEngine.load_profiles() p_data = profiles.get(profile_name, {}) c1, c2 = st.columns(2) path_s = c1.text_input("Source Folder", value=p_data.get("tab5_source", "/storage"), key="t5_s") path_o = c2.text_input("Output Folder", value=p_data.get("tab5_out", "/storage"), key="t5_o") + # Save if changed if path_s != p_data.get("tab5_source") or path_o != p_data.get("tab5_out"): if st.button("💾 Save Settings"): SorterEngine.save_tab_paths(profile_name, t5_s=path_s, t5_o=path_o) trigger_refresh() st.rerun() - if not os.path.exists(path_s): return + if not os.path.exists(path_s): + st.warning("⚠️ Source path does not exist.") + return + # --- 3. RENDER SIDEBAR --- with st.sidebar: + # We pass path_o to show the Green Dots on the number grid render_sidebar_content(path_o) + # --- 4. VIEW SETTINGS --- with st.expander("👀 View Settings"): c_v1, c_v2 = st.columns(2) page_size = c_v1.slider("Images per Page", 12, 100, 24, 4) grid_cols = c_v2.slider("Grid Columns", 2, 8, 4) - # Load Files (Cached) + # --- 5. LOAD FILES (Cached) --- all_images = get_cached_images(path_s, st.session_state.t5_file_id) if not all_images: st.info("No images found.") return - # Pagination Math + # --- 6. PAGINATION MATH --- total_items = len(all_images) total_pages = math.ceil(total_items / page_size) + + # Safety bounds if st.session_state.t5_page >= total_pages: st.session_state.t5_page = max(0, total_pages - 1) if st.session_state.t5_page < 0: st.session_state.t5_page = 0 @@ -465,26 +474,27 @@ def render(quality, profile_name): end_idx = start_idx + page_size current_batch = all_images[start_idx:end_idx] - # --- 1. CALCULATE GREEN DOTS ONCE (Optimized) --- - staged_data = SorterEngine.get_staged_data() - # We pass 'frozenset' so the cache works efficiently - green_dots_set = get_cached_green_dots(all_images, page_size, frozenset(staged_data.keys())) + # --- 7. CALCULATE GREEN DOTS (Optimized/Cached) --- + staged = SorterEngine.get_staged_data() + # Frozenset is required for caching to work on a dictionary keyset + green_dots_set = get_cached_green_dots(all_images, page_size, frozenset(staged.keys())) - # --- 2. RENDER UI --- + # --- 8. RENDER UI COMPONENTS --- + st.divider() - # CORRECTED CALL: Pass 'current_page' and 'green_dots_set' + # TOP PAGINATION render_pagination_carousel("top", total_pages, st.session_state.t5_page, green_dots_set) + # GALLERY GRID render_gallery_grid(current_batch, quality, grid_cols, path_o) st.divider() - # CORRECTED CALL + # BOTTOM PAGINATION render_pagination_carousel("bot", total_pages, st.session_state.t5_page, green_dots_set) st.divider() - render_batch_actions(current_batch, path_o, st.session_state.t5_page + 1, path_s) - st.divider() + # BATCH ACTIONS (Only called ONCE here) render_batch_actions(current_batch, path_o, st.session_state.t5_page + 1, path_s) \ No newline at end of file